Repository navigation
Conversation
Owner
Author
|
Superseded by #1916 (already merged and released in v0.302.74.78). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1914
Summary
hasWordscan inrequestsLocalEdit(src/mcp_run_task_guard.zig) with a pure clause-aware word scanner that tracks negation words (no,not,never,without,avoid,don't/don’t,doesn't,won't,cannot/can't,mustn't,shouldn't,zero,neither,nor,non,skip,forbid,prohibit) and resets negation at sentence boundaries (.,!,?,;, newlines — without tripping on filenames likeREADME.md) and contrast/directive conjunctions (but,however,instead,except,yet,please,only)."No edits."or"Do not edit or modify any files."are no longer falsely rejected as local workspace edits, while positive edit requests and mixed clauses (e.g."No edits to README.md, but update src/main.zig.") remain blocked and server--safeboundaries stay intact.Tests
#1914: negated edit instructions are allowed for read-only external run_task while positive edits stay blockedinsrc/mcp_run_task_guard.zig— fails onmain, passes with this fix.zig build unit(full unit suite),zig fmt --check,scripts/check-zig-lines.sh, andscripts/eval-tier1.sh(fmt,lines,spec,reach,build,shell,terminal,invariants,sdk).